There is some concern that these iput()'s could be the final iputs and could
induce lockups on people waiting on writeback. This would happen in the
rare case that we don't create ordered extents because of an error, but it
is theoretically possible and we already have a mechanism to deal with this
so just make them delayed iputs to negate any worry. Thanks,
Signed-off-by: Josef Bacik <jo...@redhat.com>
---
fs/btrfs/inode.c | 6 ++++--
1 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/fs/btrfs/inode.c b/fs/btrfs/inode.c
index fe3073e..a78f5c7 100644
--- a/fs/btrfs/inode.c
+++ b/fs/btrfs/inode.c
@@ -987,7 +987,7 @@ static noinline void async_cow_start(struct btrfs_work
*work)
async_cow->start, async_cow->end, async_cow,
&num_added);
if (num_added == 0) {
- iput(async_cow->inode);
+ btrfs_add_delayed_iput(async_cow->inode);
async_cow->inode = NULL;
}
}
@@ -1022,8 +1022,10 @@ static noinline void async_cow_free(struct btrfs_work
*work)
{
struct async_cow *async_cow;
async_cow = container_of(work, struct async_cow, work);
- if (async_cow->inode)
+ if (async_cow->inode) {
+ btrfs_add_delayed_iput(async_cow->inode);
iput(async_cow->inode);
+ }
kfree(async_cow);
}
--
1.7.7.6
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
