On 09/14/2012 08:42 PM, Josef Bacik wrote: > On Fri, Sep 14, 2012 at 02:58:03AM -0600, Liu Bo wrote: >> While testing xfstests 068, I realized that >> >> commit bd7de2c9a449e26a5493d918618eb20ae60d56bd >> (Btrfs: fix deadlock with freeze and sync V2) >> >> did not fix the bug yet, since someone might jump in between checking >> running transaction and joining transaction, and we may still run into >> deadlock between freeze and sync. >> >> So IMO the safest and most efficient way is to check running transaction >> in joining a transaction directly. >> >> With this patch, I tested xfstests 068 for 120 times and it did not get >> into deadlock at least here. >> > > This doesn't do anything since sync() won't have a transaction already started > so this will always just return and we won't do a commit, NAK. Thanks, >
Yeah, I'm digging this one, there is something wrong elsewhere, and Miao has pointed my fault :) thanks, liubo > Josef > -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
