Hi Josef,
in send code, in full_send_tree() there is code like this:
key.objectid = found_key.objectid;
key.type = found_key.type;
key.offset = found_key.offset + 1;
ret = btrfs_next_item(send_root, path);
if (ret < 0)
goto out;
if (ret) {
ret = 0;
break;
It wants to jump to the next greater key in the tree, whatever
objectid it has (the reason is that here we need to traverse the whole
file tree). I believe with your change it might get broken... What do
you think?
Thanks,
Alex.
On Tue, Oct 2, 2012 at 5:30 PM, Arne Jansen <sensi...@gmx.net> wrote:
> On 02.10.2012 17:27, Josef Bacik wrote:
>> On Tue, Oct 02, 2012 at 09:05:43AM -0600, David Sterba wrote:
>>> On Tue, Oct 02, 2012 at 10:32:32AM -0400, Josef Bacik wrote:
>>>> On Tue, Oct 02, 2012 at 08:25:38AM -0600, David Sterba wrote:
>>>>> Hi,
>>>>>
>>>>> On Mon, Sep 24, 2012 at 04:02:59PM -0400, Josef Bacik wrote:
>>>>>> --- a/fs/btrfs/ctree.h
>>>>>> +++ b/fs/btrfs/ctree.h
>>>>>> @@ -571,6 +571,7 @@ struct btrfs_path {
>>>>>> unsigned int skip_locking:1;
>>>>>> unsigned int leave_spinning:1;
>>>>>> unsigned int search_commit_root:1;
>>>>>> + unsigned int shecantgoanyfarthercapt:1;
>>>>>
>>>>> so you did not make it to LWN's quote of the week, can you please rename
>>>>> it to something sensible?
>>>>>
>>>>
>>>> I don't see what's unsensible about it.
>>>
>>> Itsfunnybuthardtoreadanddoesnothelpunderstandingthecodewhereitsused.
>>>
>>
>> Idisagreeithinkithelpstremendouslywiththeunderstandingofthecode,youcantgoanyfarther,butfineineedotaddacommenttobtrfs_next_leafanywaysoi'llnameitsomethingelse,anysuggestions?
>>
>
> wecantgoanyfarther
>
>> Josef
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
>> the body of a message to majord...@vger.kernel.org
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
> the body of a message to majord...@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
