On Mon, 15 Oct 2012 22:15:16 +0200, David Sterba wrote: > On Mon, Oct 15, 2012 at 07:09:23PM +0200, Bob Marley wrote: >> I would really appreciate a systemcall (or ioctl or the like) to allow >> deduplication of a block of a file against a block of another file. >> (ok if blocks need to be aligned to filesystem blocks) > > It exists, is called > > BTRFS_IOC_CLONE_RANGE > (http://lxr.free-electrons.com/source/fs/btrfs/ioctl.h#L399) > > btrfs_ioctl_clone_range_args > http://lxr.free-electrons.com/source/fs/btrfs/ioctl.h#L254 > >> The syscall should presumably check that the regions are really equal >> and perform the deduplication atomically. >> >> This would be the start for a lot of deduplication algorithms in >> userspace. >> It would be a killer feature for backup systems. > > It doesn't do any checks if the range contents match, but for a backup > system, the ranges can be merged at a calm state, ie not new data in > flight.
Thanks for bringing this up. I'm the author of bedup[1], a btrfs deduplication tool which currently uses the IOC_CLONE_RANGE syscall (and a host of other btrfs features: search, fiemap, inode-to-path backrefs, etc). By far the biggest drawback is that the same-range check is done in userland; that means I need to lock files in userland to guarantee I have exclusive access to both files at the time the clone call is done. I've found a way that might be okay against non-root users, but I wouldn't swear to it, and if it isn't that creates a security risk. The other drawbacks come from CLONE_RANGE being a write operation. It can't be done with read-only subvolumes, which is a shame because backup filesystems containing mostly read-only snapshots are a great candidate for deduplication. And it updates the mtime, when deduplication should be an implementation detail with no impact on file metadata. Now, here's my proposal for fixing that: A BTRFS_IOC_SAME_RANGE ioctl would be ideal. Takes two file descriptors, two offsets, one length, does some locking, checks that the ranges are identical (returns EINVAL if not), and defers to an implementation that works like clone_range with the metadata update and the writable volume restriction moved out. I didn't go with something block-based or extent-based because with compression and fragmentation, extents would very easily fail to be aligned. Thoughts on this interface? Anyone interested in getting this implemented, or at least providing some guidance and patch review? [1] https://github.com/g2p/bedup#readme -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
