On Sat, Nov 10, 2012 at 9:31 AM, Alun <alun.bt...@ty-penguin.org.uk> wrote: > Hi, > > (I'm not a list member and may not see any responses to this) > > I've been using btrfs on my Raspberry Pi. Yesterday I tried to use the > "btrfs scrub" function and, while the scrub started OK, I couldn't run > "btrfs scrub status" to see what was happening. Whenever I ran it, I > just got the command help. > > The same command on my x86 box worked OK. Checking out the git sources, > I found that, in a couple of places, "char c" is used to store the > return value from getopt. On the Pi, char is unsigned, so the > subsequent test for getopt returning -1 never succeeds. > > I'm attaching a patch to fix this. > > Cheers, > Alun.
We should probably also use -fsigned-char for CFLAGS in the Makefile. Who knows if there will ever be other places where the signess of char matters. -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
