On Sun, Jan 06, 2013 at 11:53:41AM +0800, Jeff Liu wrote: > - devid = simple_strtoull(devstr, &end, 10); > + ret = kstrtoull(devstr, 10, &devid); > + if (ret) { > + pr_err("btrfs: resizer unable to parse device %s\n", > + devstr);
Code looks ok, I would prefer the message error text to say: pr_err("btrfs: resize unable to parse device id %s\n", devstr); but that's maybe just me :) david -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html