Here is the whole story:
Trans_Attach_Task Trans_Commit_Task
btrfs_commit_transaction()
|->wait writers to be 1
btrfs_attach_transaction() |
btrfs_commit_transaction() |
| |->set trans_no_join to 1
| | (close join transaction)
|->btrfs_run_ordered_operations |
(Those ordered operations |
are added when releasing |
file) |
|->btrfs_join_transaction() |
|->wait_commit() |
|->wait writers to be 1
Then these two tasks waited for each other.
As we know, btrfs_attach_transaction() is used to catch the current
transaction, and commit it, so if someone has committed the transaction,
it is unnecessary to join it and commit it, wait is the best choice
for it. In this way, we can fix the above problem.
Signed-off-by: Miao Xie <mi...@cn.fujitsu.com>
---
fs/btrfs/transaction.c | 8 ++++++++
1 files changed, 8 insertions(+), 0 deletions(-)
diff --git a/fs/btrfs/transaction.c b/fs/btrfs/transaction.c
index f154946..7be9d5e 100644
--- a/fs/btrfs/transaction.c
+++ b/fs/btrfs/transaction.c
@@ -285,6 +285,14 @@ static int may_wait_transaction(struct btrfs_root *root,
int type)
if (type == TRANS_USERSPACE)
return 1;
+ /*
+ * If we are ATTACH, it means we just want to catch the current
+ * transaction and commit it. So if someone is committing the
+ * current transaction now, it is very glad to wait it.
+ */
+ if (type == TRANS_ATTACH)
+ return 1;
+
if (type == TRANS_START &&
!atomic_read(&root->fs_info->open_ioctl_trans))
return 1;
--
1.6.5.2
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
