On Fri, Feb 22, 2013 at 11:03:25AM -0800, Zach Brown wrote: > > Next, since previously we had btrfs on sdb and mkfs.ext4 > > does not overwrite super-block mirror 1.. so > > > > btrfs_read_dev_super(int fd, struct btrfs_super_block *sb, u64 > > sb_bytenr) > > > > finds btrfs on sdb. > > btrfs-progs shouldn't be unconditionally trusting the backup superblocks > if the primary is garbage. It should only check the backups if the user > specifically asks it to.
Agreed. Let me add that all the rescue tools should accept a parameter to pick the backup superblocks. Currently fsck -s, select-super -s, restore -u (though I'd like see all the option names unified, 'S' is my candidate that would not break compatibility). david -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
