On Fri, Mar 01, 2013 at 11:47:50AM -0600, Eric Sandeen wrote:
> On 3/1/13 4:10 AM, Anand Jain wrote:
> > Signed-off-by: Anand Jain <anand.j...@oracle.com>
> 
> Revieed-by: Eric Sandeen <sand...@redhat.com>
> 
> But the curious side of me wonders how it got this way.
> 
> commit e43cc461550130494194201037590a2b1f0f6880
> Author: Ian Kumlien <po...@demius.net>
> Date:   Fri Feb 8 01:37:02 2013 +0100
> 
>     Btrfs-progs: add restore command to btrfs
> 
> added the usage text below, but didn't change the getopt
> or add code to handle them.
> 
> No idea where it came from, it wasn't in the standalone
> restore either.  *shrug*  I guess nothing got lost.

   -m was definitely a thing at some point, as I recall using it. I
think the code was in josef's progs tree. I suspect the other options
were part of that, too. (And -m was definitely really useful for me).

   Hugo.

> -Eric
> 
> > ---
> >  cmds-restore.c | 4 ----
> >  1 file changed, 4 deletions(-)
> > 
> > diff --git a/cmds-restore.c b/cmds-restore.c
> > index 9385042..4a14f93 100644
> > --- a/cmds-restore.c
> > +++ b/cmds-restore.c
> > @@ -763,10 +763,6 @@ const char * const cmd_restore_usage[] = {
> >     "-f <offset>     filesystem location",
> >     "-u <block>      super mirror",
> >     "-d              find dir",
> > -   "-r <num>        root objectid",
> > -   "-c              ignore case in regular expression",
> > -   "-m <regexp>     regular expression to match",
> > -   "-l              list roots",
> >     NULL
> >  };
> >  
> > 
> 

-- 
=== Hugo Mills: hugo@... carfax.org.uk | darksatanic.net | lug.org.uk ===
  PGP key: 515C238D from wwwkeys.eu.pgp.net or http://www.carfax.org.uk
              --- Welcome to Rivendell,  Mr Anderson... ---              

Attachment: signature.asc
Description: Digital signature

Reply via email to