On Fri, Apr 05, 2013 at 01:38:16PM +0200, Jan Schmidt wrote:
> + if (root->fs_info->qgroup_flags & BTRFS_QGROUP_STATUS_FLAG_RESCAN) {
I was wondering if merging qgroup_flags with fs_state would make sense
to you. There are currently 3 bits for qgroups, and it's a whole
filesystem state anyway.
> + pr_debug("current progress key (%llu %u %llu), search_slot ret %d\n",
> + fs_info->qgroup_rescan_progress.objectid,
> + fs_info->qgroup_rescan_progress.type,
> + fs_info->qgroup_rescan_progress.offset, ret);
Please use (unsigned long long) for u64 types (objectid, offset).
> --- a/include/uapi/linux/btrfs.h
> +++ b/include/uapi/linux/btrfs.h
> @@ -376,12 +376,17 @@ struct btrfs_ioctl_get_dev_stats {
>
> #define BTRFS_QUOTA_CTL_ENABLE 1
> #define BTRFS_QUOTA_CTL_DISABLE 2
> -#define BTRFS_QUOTA_CTL_RESCAN 3
> +/* 3 has formerly been reserved for BTRFS_QUOTA_CTL_RESCAN */
It's not clear if 3 can be reused or not. If yes, there's no need for
the comment, if not, a #define should be left in place to capture the
value.
> struct btrfs_ioctl_quota_ctl_args {
> __u64 cmd;
> __u64 status;
> };
>
> +struct btrfs_ioctl_quota_rescan_args {
> + __u64 flags;
> + __u64 progress;
Like I'm always worried about future etensions, adding a few reserved[]
does not hurt.
david
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
