On Wed, Apr 24, 2013 at 02:17:48AM -0600, Liu Bo wrote: > On Tue, Apr 23, 2013 at 02:20:22PM -0400, Josef Bacik wrote: > > We kept leaking extent buffers when mounting a broken file system and it > > turns > > out it's because not everybody uses read_tree_block properly. You need to > > check > > and make sure the extent_buffer is uptodate before you use it. This patch > > fixes > > everybody who calls read_tree_block directly to make sure they check that > > it is > > uptodate and free it and return an error if it is not. With this we no > > longer > > leak EB's when things go horribly wrong. Thanks, > > What about hook the check into read_tree_block()? > > That way we can save much efforts.
Because other people do other things when it gets back from read_tree_block(), the readahead code and the search ahead code to name a few. Thanks, Josef -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
