Quoting Zach Brown (2013-06-10 18:39:58) > On Tue, Jun 04, 2013 at 04:26:57PM -0700, Zach Brown wrote: > > On Tue, Jun 04, 2013 at 07:16:53PM -0400, Chris Mason wrote: > > > Quoting Zach Brown (2013-06-04 18:17:54) > > > > Hi gang, > > > > > > > > I finally sat down to fix that readdir hang that has been in the back > > > > of my mind for a while. I *hope* that the fix is pretty simple: just > > > > don't manufacture a fake f_pos, I *think* we can abuse f_version as an > > > > indicator that we shouldn't return entries. Does this look reasonable? > > > > > > I like it, and it doesn't look too far away from how others are abusing > > > f_version. Have you tried with NFS? I don't think it'll hurt, but NFS > > > loves to surprise me. > > > > Mm, no, I hadn't. I'll give it a go tomorrow. What could go wrong? :) > > Or a week later. Pretty close! > > I couldn't get NFS to break. Clients see new entries created directly > in the exported btrfs and on either of noac and actime=1 client mounts. > For whatever that's worth.
Great. > > But I did find that I'd broken the case of trying to re-enable readdir > results by seeking past the last entry (which happens to be the current > f_pos now that we're using f_version). > > Here's the incremental fix against what Josef has in -next. I'm cool > with either squashing or just committing it. Lets squash it in, Josef loves to rebase. -chris -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
