On 8/9/13 5:48 PM, David Sterba wrote: > On Fri, Aug 09, 2013 at 03:20:47PM -0500, Eric Sandeen wrote: >> Mark many functions as static, and remove any resulting dead code. > > Thanks. > >> -struct btrfs_root *link_subvol(struct btrfs_root *root, const char *base, >> - u64 root_objectid) >> +static struct btrfs_root * >> +link_subvol(struct btrfs_root *root, const char *base, u64 root_objectid) > > Please keep the function defintion style if possible. I've fixed that at > commit time, no need to resend.
Ok, fair enough - so preferred is <lots of type stuff> function(some args . . , . . . more args . . ., . . . last args) ? sorry, old xfs habits die hard. ;) -Eric > david > -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html