On 09/28/2013 02:32 AM, Zach Brown wrote:
@@ -49,14 +50,17 @@ static int cmd_add_dev(int argc, char **argv) int i, fdmnt, ret=0, e; DIR *dirstream = NULL; int discard = 1; + int force = 0; + char estr[100];+ res = test_dev_for_mkfs(argv[i], force, estr); + if (res) { + fprintf(stderr, "%s", estr); continue; }This test_dev_for_mkfs() error string interface is bad. The caller should not have to magically guess the string size that the function is going to use. Especially because users can trivial provide giant paths that exhaust that tiny buffer. If an arbitrarily too small buffer in the caller was needed at all, its length should have been passed in with the string pointer. (Or a string struct that all C projects eventually grow.) But all the callers just immediately print it anyway. Get rid of that string argument entirely and just have test_dev_for_mkfs() print the strings.
Right. But this patch didn't introduce test_dev_for_mkfs() revamp of it will be good in a separate patch as it touches other functions as well. Thanks, Anand -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
