On Tue, Oct 22, 2013 at 01:53:21PM +0800, Anand Jain wrote: > get_btrfs_mount is reusable function but it is printing > errors, this removes it. Here the parent function of > open_path_or_dev_mnt does print error msg on error.
Yeah, but then each caller should duplicate the is_block_device check to keep get_btrfs_mount silent. There should be 2 functions, one that does all the error checking and prints error messages and one that is silent and usable eg. from a library. I'll keep the patch as-is for now because there are no other users than open_path_or_dev_mnt and the function is not exported to library. david -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
