On Sat, Nov 16, 2013 at 06:09:00PM +0100, Goffredo Baroncelli wrote: > the following patches implement the recursively snapshotting and > deleting of a subvolume.
Nice feature, but can we try to make the snapshot creation atomic? This would need support from kernel of course. I'm worried about the outcome from the users' perspective, the consistency of the whole subvolume subtree. As you've implemented it, there are several operations involved like traversing the subvolume list, replacing the empty-subvols with the real ones, taking the snapshots. The assumptions about existing source subvolumes may change in the meantime: renamed or deleted. The recursive deletion is safer form this point, I'll look at the patches closer. Deleting the whole directory subtree with randomly scattered subvolumes is not easy atm, I'm using wrappers around find and maxdepth/mindepth to look for subvols and issue delete until it's done. david -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
