On Fri, Dec 13, 2013 at 05:59:46PM +0800, Gui Hecheng wrote: > Originally, btrfstune will fail without any options and just exit > with no failure prompt.
Works for me: $ ./btrfstune usage: btrfstune [options] device -S value enable/disable seeding -r enable extended inode refs -x enable skinny metadata extent refs > Now, the number of arguments are checked before parse options > and error msg will show up upon failure. No, the arguments should be parsed first. The btrfstune utility does not use the same parser helpers like check_argc_exact and actually the bug you see could be caused by missing optind = 1 before the while () loop. Can you please test if this helps? --- a/btrfstune.c +++ b/btrfstune.c @@ -115,6 +115,7 @@ int main(int argc, char *argv[]) int skinny_flag = 0; int ret; + optind = 1; while(1) { int c = getopt(argc, argv, "S:rx"); if (c < 0) -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html