On Wed, Jan 15, 2014 at 09:35:17AM +0800, Liu Bo wrote:
> > > @@ -430,6 +430,15 @@ struct btrfs_ioctl_get_dev_stats {
> > > __u64 unused[128 - 2 - BTRFS_DEV_STAT_VALUES_MAX]; /* pad to 1k */
> > > };
> > >
> > > +/* deduplication control ioctl modes */
> > > +#define BTRFS_DEDUP_CTL_ENABLE 1
> > > +#define BTRFS_DEDUP_CTL_DISABLE 2
> > > +#define BTRFS_DEDUP_CTL_SET_BS 3
> > > +struct btrfs_ioctl_dedup_args {
> > > + __u64 cmd;
> > > + __u64 bs;
> >
> > I've spotted that you did not reserve any space for future extensions of
> > the ioctl, especially the in-band dedup can be quite heavy, I think
> > we'll want some tunables in the future.
> >
>
> Good point, I think 128 bytes can be enough for that, agree?
Yes, should be enough.
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
