On Thu, May 15, 2014 at 12:53:52PM -0500, Eric Sandeen wrote: > So, in my testing, I found that re-mkfsing a device with the same UUID lead > to weird & distant segfaults in other bits of code. Probably due to the > uuid cache? </handwave> - I didn't dig into it, because ...
Ok, something that needs more debugging, the uuid/blkid cache is a good guess I think. > ... people didn't want to be able to create duplicate UUIDs, so I figured > the outright rejection of that was a trivial way to solve it ... > > And like I mentioned, if you really want to recreate the same UUID, you > can mkfs twice. It doesn't take long. ;) > > I dunno, maybe that's too lame. For a feature that upstream development > doesn't really seem to want, I'm not sure how much more effort I should > put into it? Well, your patch allows to create a filesytem with a given UUID in the safe case. There are workarounds if the UUID is not unique for the same fs (run twice, or wipefs first). That's enough for me to integrate the V3 patch and we can address creating duplicate UUIDs separately once we can make it work correctly. -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
