On Tue, May 13, 2014 at 09:03:04PM -0500, Eric Sandeen wrote: > If we point btrfs-show-super at a not-btrfs-device and > try to print all superblocks, bad things are apt to happen: > > superblock: bytenr=274877906944, device=/dev/sdc2 > --------------------------------------------------------- > btrfs-show-super: ctree.h:1984: btrfs_super_csum_size: Assertion `!(t >= > (sizeof(btrfs_csum_sizes) / sizeof((btrfs_csum_sizes)[0])))' failed. > csum 0xAborted > > Don't try to print superblocks that don't look like superblocks, > and add an "-f" (force) option to try anyway, if the user > really wants to give it a shot.
The option -f clashes with "add sys_chunk_array and backup roots info to show-super" from Gui Hecheng. I've merged the changes and renamed yours to -F. > Fix some spelling & capitalization while we're at it. The manpage fixes do not apply to the asciidoc (already there). > The manpage says that if any problem happens, 1 will > be returned, but that's already not true today LOL, so > I didn't bother to make it true when we detect bad > sb magic, either... > > I figure it's worth continuing and trying all superblocks > in case just one has a corrupt magic. Makes sense. -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
