On Fri, May 16, 2014 at 05:20:56PM +0900, Hidetoshi Seto wrote: > Current error messages are like following: > Error: unable to create FS with metadata profile 32 (have 2 devices) > Error: unable to create FS with metadata profile 256 (have 2 devices) > > Obviously it is hard for users to interpret "profile XX" to proper > meaning, such as "raidN". So use recongizable string instead of > internal numerical value. In case of "dup", use an explicit message. > > Plus this patch fix a bug that message mistake metadata profile > for data profile. > > After applying this patch, messages will be like: > Error: dup is not allowed when FS have multiple devices > Error: unable to create FS with metadata profile RAID6 (have 2 > devices but 3 devices are required)
Nice, thanks. Moving the group_profile_* functions to utils.c was done in "Enhance the command btrfs filesystem df", so your patch ends up a bit shorter. I've modified the 'dup' to be 'DUP' in the error message and changelog so it's consistent with spelling of the RAIDx names. -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
