On Sun, May 18, 2014 at 10:40:42PM -0700, Adam Buchbinder wrote: > A mdrestore_struct was being written to without its mutex being held. > This race was found with ThreadSanitizer; the relevant part of the report > looks like this: > > WARNING: ThreadSanitizer: data race (pid=18828) > Write of size 8 at 0x7fffffc3d088 by main thread: > #0 build_chunk_tree .../btrfs-progs/btrfs-image.c:2233 > #1 __restore_metadump .../btrfs-progs/btrfs-image.c:2294 > #2 restore_metadump .../btrfs-progs/btrfs-image.c:2345 > #3 main .../btrfs-progs/btrfs-image.c:2545 > > Previous read of size 8 at 0x7fffffc3d088 by thread T1 (mutexes: write M0): > #0 restore_worker .../btrfs-progs/btrfs-image.c:1636 > > Location is stack of main thread. > > Mutex M0 created at: > #0 pthread_mutex_init ??:0 > #1 mdrestore_init .../btrfs-progs/btrfs-image.c:1766 > #2 __restore_metadump .../btrfs-progs/btrfs-image.c:2286 > #3 restore_metadump .../btrfs-progs/btrfs-image.c:2345 > #4 main .../btrfs-progs/btrfs-image.c:2545 > > Thread T1 (tid=18830, running) created by main thread at: > #0 pthread_create ??:0 > #1 mdrestore_init .../btrfs-progs/btrfs-image.c:1784 > #2 __restore_metadump .../btrfs-progs/btrfs-image.c:2286 > #3 restore_metadump .../btrfs-progs/btrfs-image.c:2345 > #4 main .../btrfs-progs/btrfs-image.c:2545 > ---
Thanks. FYI, I've added your Signed-off-by line, same as in the other patch you've sent. -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
