On Mon, May 26, 2014 at 05:30:26PM +0800, Anand Jain wrote: > --- a/fs/btrfs/volumes.c > +++ b/fs/btrfs/volumes.c > @@ -2084,6 +2084,7 @@ int btrfs_init_new_device(struct btrfs_root *root, char > *device_path) > mutex_unlock(&root->fs_info->fs_devices->device_list_mutex); > > if (seeding_dev) { > + char fsid_buf[37];
Is there a symbolic constant available? We have one in userspace, but I can't find one for kernel, only a few locally defined. > ret = init_first_rw_device(trans, root, device); > if (ret) { > btrfs_abort_transaction(trans, root, ret); > @@ -2094,6 +2095,13 @@ int btrfs_init_new_device(struct btrfs_root *root, > char *device_path) > btrfs_abort_transaction(trans, root, ret); > goto error_trans; > } > + > + /* Sprouting would change fsid of the mounted root, > + * so rename the fsid on the sysfs > + */ > + sprintf(fsid_buf, "%pU", root->fs_info->fsid); Would be better do use snprintf explicitly. > + if (kobject_rename(&root->fs_info->super_kobj, fsid_buf)) > + goto error_trans; > } else { Otherwise ok. -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html