On Wed, Oct 15, 2014 at 9:20 PM, Josef Bacik <jba...@fb.com> wrote: > On 10/15/2014 03:30 PM, Rich Freeman wrote: >> >> On Wed, Oct 15, 2014 at 10:30 AM, Josef Bacik <jba...@fb.com> wrote: >>> >>> We've found it, the Fedora guys are reverting the bad patch now, we'll >>> get >>> the fix sent back to stable shortly. Sorry about that. >> >> >> After reverting this commit, can the bad snapshots be >> deleted/repaired/etc without wiping and restoring the entire >> filesystem? Copying 2.3TB of data isn't a particularly fast >> operation... >> > > I would certainly like to make fsck repair this sort of problem, let me > reproduce the corruption locally and then make fsck fix it and then you can > use that. Thanks,
I just sent out a patch for fsck to fix this issue - i.e. bad read-only snapshots (inaccessible without errors, impossible to delete, etc). It fixes the snapshots if, and only if, you haven't run fsck in repair mode (--repair) before, as that would touch back references and other metadata as it didn't expect for root items to incorrect (which is essentially what the snapshots bug made). The patch is this one: https://patchwork.kernel.org/patch/5098331/ Also, if you have errors accessing files through a path that doesn't contain any of the read-only snapshots, it's possible that it's the corruption bug we had in 3.17 - bad extent map manipulation, that manifests itself in several ways (e.g. reports: http://www.spinics.net/lists/linux-btrfs/msg38045.html and http://www.spinics.net/lists/linux-btrfs/msg37567.html). Anyway, if you run into further issues, please report them. thanks > > Josef > > > -- > To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in > the body of a message to majord...@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- Filipe David Manana, "Reasonable men adapt themselves to the world. Unreasonable men adapt the world to themselves. That's why all progress depends on unreasonable men." -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
