On Mon, Feb 09, 2015 at 02:11:52PM +0800, Qu Wenruo wrote: > Although fsck-test/012 uses sudo, it uses 'sudo -n', which won't prompt > user to input password and will return 1 if no valid credential is > found. > > And this makes test result quite annoying since it fails to mount and > still continue, which will always fail. > > This patch introduced the new check_sudo() to check sudo before calling > $sudo. This function will check "sudo -v -n" to get the credential. > And if it fails, then the test will not be run.
This logic is fine, but the setup fails for me even if typing the password is not required. I think the 'sudo -v' check is wrong as it tries to refresh the credentials. $ sudo -v -n sudo: a password is required while $ sudo -n /bin/true works. -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
