Hi Josef, On Thu, Sep 18, 2014 at 11:20:02AM -0400, Josef Bacik wrote: > --- a/fs/btrfs/disk-io.c > +++ b/fs/btrfs/disk-io.c > @@ -1764,6 +1764,7 @@ static int cleaner_kthread(void *arg) > } > > btrfs_run_delayed_iputs(root); > + btrfs_delete_unused_bgs(root->fs_info); > again = btrfs_clean_one_deleted_snapshot(root); > mutex_unlock(&root->fs_info->cleaner_mutex);
any reason to put the dirty bg deletion before snapshot cleaning? If the snapshot unpins some old data there is higher chance to remove some bgs after that. This is not a problem as the cleaner loop may be triggered for other reasons (iputs, autodefrag, more than one snapshot in the queue) but still would make more sense to do it after the deletion. Thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
