Hi, David Sterba Thanks for review this patch.
> -----Original Message----- > From: David Sterba [mailto:dste...@suse.com] > Sent: Thursday, August 06, 2015 12:51 AM > To: Zhao Lei > Cc: linux-btrfs@vger.kernel.org > Subject: Re: [PATCH] btrfs-progs: Modify confuse error message in scrub > > On Wed, Aug 05, 2015 at 04:32:26PM +0800, Zhao Lei wrote: > > Scrub output following error message in my test: > > ERROR: scrubbing /var/ltf/tester/scratch_mnt failed for device id 5 > > (Success) > > > > It is caused by a broken kernel and fs, > > In what way is it broken? Can we turn it into tests? > It is caused by my custom-made condition, created for debugg another problem in kernel code, and see above outout in xfstests. It is not a real problem for normal user, so not necessary to add A testcase to fstests and user-land tests. But for btrfs-progs, it should not output such message on any case, this is what this patch fixed. > > but the we need to avoid > > outputting both "error and success" in oneline message as above. > > > > This patch modified above message to: > > ERROR: scrubbing /var/ltf/tester/scratch_mnt failed for device id 5, > > ret=1, errno=0(Success) > > The net effect of the patch is to add ret=.. and errno=.. to the error message > but it also changes a series of ifs to a switch. This belongs to a separate > patch. OK, will send v2. Thanks Zhaolei -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
