David Sterba wrote on 2015/08/27 11:14 +0200:
On Mon, Aug 03, 2015 at 03:18:55PM +0800, Qu Wenruo wrote:
Implement details includes the following:
1) LRU hash maps to limit the memory usage
The hash -> extent mapping is control by LRU (or unlimited), to
get a controllable memory usage (can be tuned by mount option)
alone with controllable read/write overhead used for hash searching.
In Liu Bo's series, I rejected the mount options as an interface and
will do that here as well. His patches added a dedup ioctl to (at least)
enable/disable the dedup.
BTW,　would you please give me some reason why that's not a good idea to
use mount option to trigger/change dedup options?
That's the wrong interface to use for such actions.
But IMHO, deduplication is much like compression, we only need to
execution extra hook to handle data at run_delalloc_range().
And even better than compression, inline dedup won't even cause any
format change.
So I'd prefer to use mount option other than introduce a new ioctl
interface.
Would you please explain more about why mount option is not a good idea
in this use case?
Thanks,
Qu
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
