On Mon, Oct 05, 2015 at 10:14:24PM +0530, Chandan Rajendra wrote:
> +     if (unlikely(root->highest_objectid >= BTRFS_LAST_FREE_OBJECTID)) {
> +             mutex_unlock(&root->objectid_mutex);
> +             ret = -ENOSPC;

ENOSPC ... I don't think it's right as this could be with a normal
enospc during subvolume creation. The problem is that theh inode number
space is exhausted, the closest error code I see is EOVERFLOW. As this
is an ioctl we can afford to define the meaning of this return value as
such (unlike for eg. creat()/open()).

> +             goto free_root_dev;
> +     }
> +
> +     mutex_unlock(&root->objectid_mutex);
> +
>       return 0;
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to