On Thu, Oct 15, 2015 at 02:19:44AM -0700, Christoph Hellwig wrote:
> > +# this test requires the test fs support reflink...
> > +#
> > +_require_test_reflink()
> > +{
> > + case $FSTYP in
> > + xfs)
> > + xfs_info "${TEST_DIR}" | grep reflink=1 -c -q || _notrun "Reflink not
> > supported by this filesystem type: $FSTYP"
> > + ;;
> > + btrfs)
> > + true
> > + ;;
> > + *)
> > + _notrun "Reflink not supported by this filesystem type: $FSTYP"
> > + ;;
> > + esac
>
> I don't think that's a good test - we need to check if it's supported by
> trying it. That'll automatically get us coverage for other file systems
> like xfs.
>
> Note that dedup should get it's own feature check, as currently hacking
> nfs into this check will also run dedup tests that can't really be
> supported.
Good point. I'll throw that in while I rework the tests.
--D
> --
> To unsubscribe from this list: send the line "unsubscribe fstests" in
> the body of a message to majord...@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
