On Mon, Feb 22, 2016 at 7:26 AM, Philippe Loctaux
<p...@philippeloctaux.com> wrote:
> On Mon, Feb 22, 2016 at 09:18:04AM +0800, Qu Wenruo wrote:
>> https://git.kernel.org/pub/scm/linux/kernel/git/mason/linux-btrfs.git
>> For branch, normally I use 'integration-X.X' as base for kernel development.
>>
>> And for btrfs-progs,
>> https://github.com/kdave/btrfs-progs.git devel
>
> Allright, I'll work from these repos!
>
> Is it fine if I work from Linus's repo?
> Will my patches get rejected if I do so?

If you want to contribute and do something useful for others and
yourself, just don't keep sending these patches to fix
whitespace/style issues reported by checkpatch.
Think about it:

1) You don't learn anything by doing them. You don't learn nothing
about btrfs internals, filesystems in general, kernel programming in
general, general programming in C, etc. It ends up being only a waste
of time for you;

2) You're not offering any benefit to users - not fixing a bug, not
adding a new feature, not doing any performance/efficiency
improvement, not making the code more reliable, etc;

3) You're not offering a benefit for other developers either, like
doing a cleanup that simplifies a complex algorithm for example.

If you care so much about the whitespace/style issues, just fix them
while doing a useful change as mentioned above that happens to touch
the same code.
It takes time to read and understand code, it can be a big investment
of time, but it ends up being worth it. There's plenty of bug reports
and performance issues in the mailing list or bugzilla, so there's no
shortage of things to do.

Same advice applies to any other kernel subsystem or open source
project in general. Also before jumping into such a storm of useless
patches, observe first what a community does for at least a month, and
learn from other contributors - what they do, how they do it, the flow
of development and releases, etc. Don't rush into a sending patch just
for the sake of sending it and having your name in the git history.

Hope it helps.


>
> --
> Philippe Loctaux
> p...@philippeloctaux.com
> --
> To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
> the body of a message to majord...@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html



-- 
Filipe David Manana,

"Reasonable men adapt themselves to the world.
 Unreasonable men adapt the world to themselves.
 That's why all progress depends on unreasonable men."
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to