On Mon, Mar 14, 2016 at 09:12:36AM +0900, Satoru Takeuchi wrote:
> --- a/cmds-property.c
> +++ b/cmds-property.c
> @@ -379,9 +379,7 @@ static int cmd_property_get(int argc, char **argv)
>       char *name = NULL;
>       int types = 0;
> 
> -     clean_args_no_options(argc, argv, cmd_property_get_usage);
> -
> -     if (check_argc_min(argc, 2) || check_argc_max(argc, 5))
> +     if (check_argc_min(argc, 2))
>               usage(cmd_property_get_usage);
> 
>       parse_args(argc, argv, cmd_property_get_usage, &types, &object, &name,

We still need to check the number of non-option arguments here, when the
optind is set from parse_args.

> @@ -415,9 +413,7 @@ static int cmd_property_set(int argc, char **argv)
> -     if (check_argc_min(argc, 4) || check_argc_max(argc, 6))
> +     if (check_argc_min(argc, 4))
>               usage(cmd_property_set_usage);

...

>       parse_args(argc, argv, cmd_property_set_usage, &types,
> @@ -446,9 +442,7 @@ static int cmd_property_list(int argc, char **argv)
> -     if (check_argc_min(argc, 2) || check_argc_max(argc, 4))
> +     if (check_argc_min(argc, 2))

...
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to