On Mon, Mar 21, 2016 at 1:49 PM, David Sterba <dste...@suse.cz> wrote: > > On Thu, Jan 28, 2016 at 10:52:28AM -0500, Dan Fuhry wrote: > > Add support for the RENAME_WHITEOUT and RENAME_EXCHANGE flags in > > renameat2(). This brings us pretty close to having btrfs ready to be > > an upper layer for overlayfs. (The last remaining issue is in > > btrfs_sync_file, which I'm looking at next if I have time.) > > The sync_file issue should be fixed by filipes' fix from today. > > > This includes Davide Italiano's implementation of RENAME_EXCHANGE. I > > quickly pinged him on github [1] last week to confirm resubmission of > > his patch which originally went to this list on 2 April 2015 and > > didn't make it in. > > > > This is my first time submitting a kernel patch, I think I've covered > > all the style recommendations, and also addressed Filipe David > > Manana's review notes [2] on Davide Italiano's patch. Certainly let me > > know if there's anything else that should be cleaned up. Thanks! > > The patch style looks, I've briefly tested it in fstests and it blows > very quickly, the stacktraces are unreadable. So I could mismerge it or > there's another reason. Anyway, I'm going to pick this patch for 4.7 and > will add it to my for-next after the crashes are resolved.
David, Thanks for looking at this. I will test against for-linus-4.6 tomorrow (unless there's a better branch to build against - I'm a noob here) and see if I can find anything obvious. I've had success with a rudimentary test that evaluates only the two new rename modes, and does not test behavior when subvolumes are involved, but have yet to subject it to a larger test suite such as xfstests. So it wouldn't surprise me if it breaks down there. I'll try and get that going on my system and see if I can reproduce. Dan -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
