On Thu, May 19, 2016 at 04:10:20PM -0400, Chris Mason wrote: > On Tue, May 17, 2016 at 10:47:27PM +0200, Adam Borowski wrote: > > On Tue, May 17, 2016 at 12:23:44PM -0400, Chris Mason wrote: > > > On Tue, May 17, 2016 at 05:14:51PM +0200, Adam Borowski wrote: > > > > On Mon, May 16, 2016 at 05:06:55PM -0400, Chris Mason wrote: > > > > > And now for the patch: > > > > [...] > > > > > > > > I then tried your test case, and alas: > > > > > > > > Here's another run on an untainted kernel built with frame pointers etc: > > > > > > > > ./dammitdave foo > > > > [ 236.500280] WARNING: CPU: 3 PID: 2940 at fs/btrfs/extent-tree.c:4233 > > > > btrfs_free_reserved_data_space_noquota+0xdd/0x160 > > > > rm foo > > > > [ 323.851851] BTRFS info (device sda1): btrfs_destroy_inode: leftover > > > > csum_bytes > > > > > > Hmmm, some of your traces mentioned compression, do you have compression > > > enabled? > > > > Yeah, I mount with noatime,compress=lzo. > > > > > I'll try to reproduce here, but could you try the same test on v4.5? > > > > I've ran it for half an hour on vanilla 4.5.4 without any patches, no > > failures of any kind. > > > > > gdb> list *__btrfs_buffered_write+0x748 > > > > 0xffffffff8152eb78 is in __btrfs_buffered_write (fs/btrfs/file.c:1564). > > Hmpf, even with forcing btrfs_delalloc_reserve_metadata to randomly > fail, I can't trigger this warning. Something else is going on. > > For now I'm going to send in the fault patch, I'm confident this new > warning is something unrelated.
After having balanced my sda1, I can't reproduce this anymore, even after having re-allocated all chunks. As the original bug produced different results (like, no warnings other than btrfs_destroy_inode:csum_bytes), it indeed looks like an unrelated regression of some kind. I re-checked both real loads and dammitdave yesterday: * 4.5.4 works ok * 4.6.0 without your patch warns btrfs_destroy_inode * 4.6.0 with the patch works ok thus, it at least fixes that one. Tested-by: Adam Borowski <kilob...@angband.pl> -- An imaginary friend squared is a real enemy. -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
