On Wed, Jun 01, 2016 at 02:15:22PM -0700, Mark Fasheh wrote: > > +/* dynamically allocate and initialize a ref_root */ > > +static struct ref_root *ref_root_alloc(void) > > +{ > > + struct ref_root *ref_tree; > > + > > + ref_tree = kmalloc(sizeof(*ref_tree), GFP_KERNEL); > > I'm pretty sure we want GFP_NOFS here.
Then please explain to me why/where the reasoning below is wrong: > > Because there's no need to narrow the allocation constraints. GFP_NOFS > > is necessary when the caller is on a critical path that must not recurse > > back to the filesystem through the allocation (ie. if the allocator > > decides to free some memory and tries tro write dirty data). FIEMAP is > > called from an ioctl. -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html