On Friday, July 15, 2016 11:44:06 AM David Sterba wrote: > On Fri, Jul 15, 2016 at 11:47:07AM +0530, Chandan Rajendra wrote: > > On Thursday, July 14, 2016 02:29:32 PM David Sterba wrote: > > > The calculation of extent_buffer::pages size was done for 4k PAGE_SIZE, > > > but this wastes 15 unused pointers on arches with large page size. Eg. > > > on ppc64 this gives 15 * 8 = 120 bytes. > > > > > > > The non PAGE_SIZE aligned extent buffer usage in page straddling tests in > > test_eb_bitmaps() need atleast one more page. So how about the following ... > > > > #define INLINE_EXTENT_BUFFER_PAGES (BTRFS_MAX_METADATA_BLOCKSIZE / > > PAGE_SIZE + 1) > > Could the extra page pointer be normally used? Ie. not just for the sake > of the tests. I'd rather not waste the bytes. As a compromise, we can do +1 > only if the tests are compiled in. >
I don't see any other scenario where the extra page pointer gets used. Also, I just executed fstests with your patch applied and disabling self-tests from the kernel configuration. The tests ran fine. -- chandan -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
