On 08/01/2016 05:47 AM, Christoph Hellwig wrote:
On Sat, Jul 30, 2016 at 04:45:48PM -0500, Shaun Tancheff wrote:
bi_rw should be using bio_set_op_attrs to set bi_rw.

Looks fine,

Reviewed-by: Christoph Hellwig <h...@lst.de>

Added, thanks Shaun.

Jens,

what do you think about renaming bi_rw?  There aren't too many users
left, and any old code that would keep using it is alsmost guranteed
to be broken, so sending a post-rc1 patch to rename it might make
everyone else life easier.  Especially as it's also grossly misnamed
now.

I was planning on doing that, after -rc1. Much better to get build
breakage, than potentially much worse breakage.

--
Jens Axboe

--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to