Automatically resuming an interrupted balance has repeatedly caused all
sorts of problems because it creates a possible failure mode when a user
can least use it: after a crash/power loss/sudden reboot (which, like it
or not, is the de facto "fix random problems" approach for many people).

The idea behind the automnatic resume is good and important for cases
like automation and unattended operation, but nevertheless right now
it creates more problems than it fixes.

As far as I can see it should be easy enough to simply disable calling
btrfs_resume_balance_async() at least on mount (in open_ctree()) and
possibly on remount as well. The skip_balance flag could then simply
be ignored or removed.

I can't say how much work it would be to completely remove the persistent
balance state or whether it is useful to be kept around for resume, but at
least not continuing would stop filesystems from eating themselves further
on mount.

Holger
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to