On Mon, Sep 19, 2016 at 08:01:05PM +0200, David Sterba wrote: > On Thu, Sep 15, 2016 at 02:58:12PM -0400, Chris Mason wrote: > > > > > > On 09/15/2016 03:01 PM, Liu Bo wrote: > > > On Wed, Sep 14, 2016 at 11:19:04AM -0700, Liu Bo wrote: > > >> On Wed, Sep 14, 2016 at 01:31:31PM -0400, Josef Bacik wrote: > > >>> On 09/14/2016 01:29 PM, Chris Mason wrote: > > >>>> > > >>>> > > >>>> On 09/14/2016 01:13 PM, Josef Bacik wrote: > > >>>>> On 09/14/2016 12:27 PM, Liu Bo wrote: > > >>>>>> While updating btree, we try to push items between sibling > > >>>>>> nodes/leaves in order to keep height as low as possible. > > >>>>>> But we don't memset the original places with zero when > > >>>>>> pushing items so that we could end up leaving stale content > > >>>>>> in nodes/leaves. One may read the above stale content by > > >>>>>> increasing btree blocks' @nritems. > > >>>>>> > > >>>>> > > >>>>> Ok this sounds really bad. Is this as bad as I think it sounds? We > > >>>>> should probably fix this like right now right? > > >>>> > > >>>> He's bumping @nritems with a fuzzer I think? As in this happens when > > >>>> someone > > >>>> forces it (or via some other bug) but not in normal operations. > > >>>> > > >>> > > >>> Oh ok if this happens with a fuzzer than this is fine, but I'd rather do > > >>> -EIO so we know this is something bad with the fs. > > >> > > >> -EIO may be more appropriate to be given while reading btree blocks and > > >> checking their validation? > > > > > > Looks like EIO doesn't fit into this case, either, do we have any errno > > > representing 'corrupted filesystem'? > > > > That's EIO. Sometimes the EIO is big enough we have to abort, but > > really the abort is just adding bonus. > > I think we misuse the EIO where we should really return EFSCORRUPTED > that's an alias for EUCLEAN, looking at xfs or ext4. EIO should be > really a message that the hardware is bad.
I love this idea, but one quick question, when returning EUCLEAN, what message do users get? "#define EUCLEAN 117 /* Structure needs cleaning */" Thanks, -liubo -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
