On Thu, Oct 13, 2016 at 12:04 PM, robbieko <robbi...@synology.com> wrote: > From: Robbie Ko <robbi...@synology.com> > > Patch for test btrfs incremental send. > > Robbie Ko (4): > btrfs: add test for an incremental send don't skip overwrite ref for > inode 256 > btrfs: add test for an incremental send add gen for is_waiting_for_rm > when some corner case > btrfs: add test for an incremental send add gen check in > did_overwrite_ref > btrfs: add test for an incremental send add gen check in > will_overwrite_ref
These should go to fste...@vger.kernel.org with linux-btrfs@vger.kernel.org in cc. Those patch subjects and change logs are too implementation specific. They should be understandable by non developers (like QA people for e.g.), think about it. Do you think such people know what is is_waiting_for_rm, did_overwrite_ref, "gen", etc? You should take a look at git history and see subjects and change logs. Both should say what is being tested, not the problems with code functions and how you solved them. Also please, if you are copy-pasting tests, don't leave me as the author there nor the SUSE copyright. > > tests/btrfs/131 | 110 +++++++++++++++++++++++++++++++++++++++++++++++ > tests/btrfs/131.out | 2 + > tests/btrfs/132 | 116 +++++++++++++++++++++++++++++++++++++++++++++++++ > tests/btrfs/132.out | 2 + > tests/btrfs/133 | 120 +++++++++++++++++++++++++++++++++++++++++++++++++++ > tests/btrfs/133.out | 2 + > tests/btrfs/134 | 121 > ++++++++++++++++++++++++++++++++++++++++++++++++++++ > tests/btrfs/134.out | 2 + > tests/btrfs/group | 4 ++ > 9 files changed, 479 insertions(+) > create mode 100755 tests/btrfs/131 > create mode 100644 tests/btrfs/131.out > create mode 100755 tests/btrfs/132 > create mode 100644 tests/btrfs/132.out > create mode 100755 tests/btrfs/133 > create mode 100644 tests/btrfs/133.out > create mode 100755 tests/btrfs/134 > create mode 100644 tests/btrfs/134.out > > -- > 1.9.1 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in > the body of a message to majord...@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- Filipe David Manana, "People will forget what you said, people will forget what you did, but people will never forget how you made them feel." -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
