On Tue, Nov 08, 2016 at 08:33:25AM +0800, Qu Wenruo wrote:
> While still some small comment.
> +                         if (!isprint(c)) {
> +                                 printf("\\%c%c%c",
> +                                                 '0' + ((c & 0300) >> 6),
> +                                                 '0' + ((c & 070) >> 3),
> +                                                 '0' + (c & 07));
> 
> For non-printable chars, isn't it more common to print it as hex other 
> than octal?

Ok, hex would be better.
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to