On Tue, Dec 06, 2016 at 12:39:37PM +0800, Anand Jain wrote: > The command, > btrfs fi defrag -v /btrfs > does nothing, it won't defrag the files under /btrfs as user > may expect. The command with recursive option > btrfs fi defrag -vr /btrfs > would defrag all the files under /btrfs including files in > its sub directories. > > While attempting to fix this. The patch below 1/1 provides > a cleanup. And the actual fix is pending, as to my understanding > of nfwt() it does not provide the list of file without > files under its sub directories.
What kind of fix do you mean? We could detect if there's a directory in the list of arguments and assume the recursive mode. I think this is what most users expect. Currently passing a directory will defragment the extent tree, but I think we should extend the defrag ioctl flags to explictly ask for that. At minimum, a directory without -r could print a warning about what it's really doing. But I'm open to other ideas. -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
