On Wed, Apr 12, 2017 at 7:05 PM, Duncan <1i5t5.dun...@cox.net> wrote: > Evan Danaher posted on Tue, 11 Apr 2017 12:33:40 -0400 as excerpted: > >> I was shocked to discover that 'btrfs receive --dump' doesn't print a >> space after long filenames, so it runs together into the metadata; for >> example: >> >> truncate ./20-00-03/this-name-is-32-characters-longsize=0 >> >> This is a trivial patch to add a single space unconditionally, so the >> result is the following: >> >> truncate ./20-00-03/this-name-is-32-characters-long size=0 >> >> I suppose this is technically a breaking change, but it seems unlikely >> to me that anyone would depend on the existing behavior given how >> unfriendly it is. >> >> Signed-off-by: Evan Danaher <git...@edanaher.net> >> --- > > I'm not a dev so won't attempt to comment on the patch itself, but it's > worth noting that according to kernel patch submission guidelines (which > btrfs-progs use as well) on V2+ patch postings, there should be a short, > often one-line per version, summary of what changed between versions. > This helps both reviewers and would-be patch-using admins such as myself > understand how a patch is evolving, as well as for reviewers preventing > unnecessary work when re-reviewing a new version of a patch previously > reviewed in an earlier version. > > On patch series this summary is generally found in the 0/N post, while on > individual patches without a 0/N, it's normally found below the first --- > delimiter, so as to avoid including the patch history in the final merged > version comment.
To be specific, something like > --- > >v2: fixed an off-by-one error which caused padding to be 33 characters for >short paths > --- instead of the email tail you currently appended (for future reference). FWIW, I'm fine with you adding my 'Reviewed-by', but I don't think it carries much weight yet. :-) -- Noah -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
