On 05/29/2017 11:43 PM, David Sterba wrote:
This patch adds the name length verification to many places and in some of them it looks unnecessary, as the directory item passes sanity checks already. The verification should always happen when we read the input, ie from disk, after search_slot etc. Then, it can be considered valid and does not need the strict checks.
I have realized the fact many checks in the patch are useless.
I haven't gone through all, one example is __add_inode_ref. The caller add_inode_ref uses namelen before it reaches __add_inode_ref (and thus the sanity checks). As the checks add error hanlind branch, the entire callgraph of the function should be verified, so I suggest to split the patch and group only hunks that touch the same codepaths.
OK, I will update and split it.
-- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
