On Mon, Jun 12, 2017 at 06:03:15PM +0200, Hans van Kranenburg wrote: > >> Most interesting changes since v1: > >> - mention the special tree_id input value 0 > >> - rewrite the part about min_key and max_key, trying to be more concise > > > > I find the description instructive enough so the expanded expression to > > describe the whole range is not IMHO needed. > > You mean drop the extra line "All metadata..." ? Yeah, it's a bit > redudant, stressing the fact, yes.
Ah, sorry I was not clear. I was referring to Goffredo's proposal with the expression how the min_key and max_key are calculated. Your text in v2 is fine. We know how to calculate one key and we know the where are the limits. > The main purpose is to stop users from thinking that setting min_type > and max_type will filter the returned objects (like, only getting > BLOCK_GROUP_ITEM_KEY or so). So as long as you think that's clear > enough, I'm ok with anything. The text looks good to me and I've added the patch to the queue. Further refinements are welcome. -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
