On Tue, Jun 13, 2017 at 04:12:10PM +0800, Anand Jain wrote: > > > On 06/13/2017 02:41 PM, Christoph Hellwig wrote: > > I thought btrfs supports 64-bit inodes, in which case this will > > truncate the inode number on 32-bit architectures. > > Good catch. Thanks ! > > Will send the updated patch.
Hold on. We should then use u64 everywhere in the tracepoints. And this would mean more extensive changes than just switching a few types. Eg. pass 'struct btrfs_inode' instead of 'struct inode', reflecting the recent changes to the function prototypes to always use btrfs_inode for any functions that do not interface to VFS. We can use the btrfs_ino helper to extract the inode number. This is already done in some places so this would unify them. And not only the inode number, there are some further cleanups possible in the tracepoints. I'd rather not divert the work to tracepoints at this moment and postpone it for next cycle, as the wgon ino types are not critical. -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
