Given that we probably don't have great testing
coverage of devices with the flush capabilities,

   Any hints on what type of test coverage ?

Devices used for normal testing, any sort of test basically, that do not
have the flush capabilities will never exercise the in write_dev_flush.

 Right. Same with -o nobarrier as well.

So any reference counts or failures will not get covered.

 hm. Still I didn't understand your point of view, sorry.
 But the contrary is also true that when device cache is enabled,
 the write_dev_flush() gets exercised, so we are fine.

 I toggled the device write cache manually for testing this set.
    # echo "write through" > /sys/block/sdd/queue/write_cache
    # echo "write back" > /sys/block/sdd/queue/write_cache


Thanks, Anand


--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to