On Wed, Jun 28, 2017 at 11:05:22AM +0300, Nikolay Borisov wrote: > The sectorsize member of btrfs_block_group_cache is unused. So remove it, this > reduces the number of holes in the struct. > > With patch: > /* size: 856, cachelines: 14, members: 40 */ > /* sum members: 837, holes: 4, sum holes: 19 */ > /* bit holes: 1, sum bit holes: 29 bits */ > /* last cacheline: 24 bytes */ > > Without patch: > /* size: 864, cachelines: 14, members: 41 */ > /* sum members: 841, holes: 5, sum holes: 23 */ > /* bit holes: 1, sum bit holes: 29 bits */ > /* last cacheline: 32 bytes */ > > Signed-off-by: Nikolay Borisov <nbori...@suse.com> > Reviewed-by: David Sterba <dste...@suse.com>
Strange that the error appeared just now, the code hasn't been modified recently. CC [M] fs/btrfs/tests/free-space-tree-tests.o fs/btrfs/tests/free-space-tree-tests.c: In function ‘__check_free_space_extents’: fs/btrfs/tests/free-space-tree-tests.c:84:20: error: ‘struct btrfs_block_group_cache’ has no member named ‘sectorsize’ offset += cache->sectorsize; ^~ make[1]: *** [scripts/Makefile.build:302: fs/btrfs/tests/free-space-tree-tests.o] Error 1 make: *** [Makefile:1684: fs/btrfs/] Error 2 I'll fix it. -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html