So it basically looks good, I could not resist and rewrote the changelog and comments. There's one code fix:
On Mon, Jul 17, 2017 at 04:52:58PM +0300, Timofey Titovets wrote: > -static inline int inode_need_compress(struct inode *inode) > +static inline int inode_need_compress(struct inode *inode, u64 start, u64 > end) > { > struct btrfs_fs_info *fs_info = btrfs_sb(inode->i_sb); > > /* force compress */ > if (btrfs_test_opt(fs_info, FORCE_COMPRESS)) > - return 1; > + return btrfs_compress_heuristic(inode, start, end); This must stay 'return 1', if force-compress is on, so the change is reverted. I'm adding the patch to for-next. > /* bad compression ratios */ > if (BTRFS_I(inode)->flags & BTRFS_INODE_NOCOMPRESS) > return 0; > if (btrfs_test_opt(fs_info, COMPRESS) || > BTRFS_I(inode)->flags & BTRFS_INODE_COMPRESS || > BTRFS_I(inode)->force_compress) > - return 1; > + return btrfs_compress_heuristic(inode, start, end); > return 0; > } -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html