On Tue, Jul 25, 2017 at 05:48:28PM +0300, Nikolay Borisov wrote: > The return value of flush_space was used to have significance in the early > days > when the code was first introduced and before the ticketed enospc rework. > Since > the latter got introduced the return value lost any significance whatsoever to > its callers. So let's remove it. While at it also remove the unused ticket > variable in btrfs_async_reclaim_metadata_space. It was used in the initial > version of the ticketed ENOSPC work, however Wang Xiaoguang detected a problem > with this and fixed it in ce129655c9d9 ("btrfs: introduce tickets_id to > determine whether asynchronous metadata reclaim work makes progress"). > > Signed-off-by: Nikolay Borisov <nbori...@suse.com>
Reviewed-by: David Sterba <dste...@suse.com> I've added a comment to the function, as it's not obvious why all the error conditions inside get ignored in the end. -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html